Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing jaeger exporters #890

Merged
merged 1 commit into from
Dec 9, 2022
Merged

removing jaeger exporters #890

merged 1 commit into from
Dec 9, 2022

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Dec 7, 2022

Jaeger has dropped support for the jaeger exporter in favour of opentelemetry exporter. The upstream repos are now archived. Support has been dropped from the opentelemetry collector, and other SIGs should follow soon.
ref: open-telemetry/opentelemetry-specification#2858 and open-telemetry/opentelemetry-specification#2859

Jaeger has dropped support for the jaeger exporter in favour of opentelemetry exporter. The upstream repos are now archived.
Support has been dropped from the opentelemetry collector, and other SIGs should follow soon.
ref: open-telemetry/opentelemetry-specification#2858 and open-telemetry/opentelemetry-specification#2859
@brettmc brettmc requested a review from a team December 7, 2022 23:28
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #890 (ad9b675) into main (7bfc121) will decrease coverage by 0.48%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #890      +/-   ##
============================================
- Coverage     81.59%   81.11%   -0.49%     
+ Complexity     2010     1905     -105     
============================================
  Files           264      252      -12     
  Lines          5226     4929     -297     
============================================
- Hits           4264     3998     -266     
+ Misses          962      931      -31     
Flag Coverage Δ
7.4 80.56% <ø> (-0.52%) ⬇️
8.0 81.09% <ø> (-0.49%) ⬇️
8.1 81.24% <ø> (-0.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bfc121...ad9b675. Read the comment docs.

@pdelewski
Copy link
Member

Jaeger has dropped support for the jaeger exporter in favour of opentelemetry exporter. The upstream repos are now archived. Support has been dropped from the opentelemetry collector, and other SIGs should follow soon. ref: open-telemetry/opentelemetry-specification#2858 and open-telemetry/opentelemetry-specification#2859

@brettmc Is not that too early? It seems that there will be deprecation period regarding removing it from spec

@brettmc
Copy link
Collaborator Author

brettmc commented Dec 8, 2022

Is not that too early? It seems that there will be deprecation period regarding removing it from spec

I missed SIG yesterday, but Bob noted that he thought better to remove it before beta. It's definitely going away (upstream are not even accepting security fixes anymore), so removing it earlier means less for us to maintain.
A deprecation makes more sense for GA libraries where people may be using it in production and need some time to migrate, but I think doesn't apply to us?

@pdelewski
Copy link
Member

Is not that too early? It seems that there will be deprecation period regarding removing it from spec

I missed SIG yesterday, but Bob noted that he thought better to remove it before beta. It's definitely going away (upstream are not even accepting security fixes anymore), so removing it earlier means less for us to maintain. A deprecation makes more sense for GA libraries where people may be using it in production and need some time to migrate, but I think doesn't apply to us?

Bob mentioned that yesterday, but after reading attached tickets, I was not sure we should do that now, however I agree that it should not apply to us

@brettmc brettmc merged commit 5a51249 into open-telemetry:main Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants